Memory Leak using StringWriter and StringReader
-1
I am using StringReader and StringWriter as following but in some events this block takes around 5 minutes to execute (whereas it normally completes in milliseconds) and it also raises high metaspace issue. Is there anything I am missing which is leading to memory leak? There are two suspect blocks:
public String getXmlFromXslt(@NonNull final String xmlString, @NonNull final String xsltInput)
throws TransformerException {
// Start Time Metric
long startTime = System.currentTimeMillis();
String result = null;
try (StringReader stringReader = new StringReader(xmlString);
StringWriter writer = new StringWriter()) {
TransformerFactory factory = TransformerFactory.newInstance();
Transformer transformer = factory.newTransformer(new StreamSource(new StringReader(xsltInput)));
transformer.transform(new StreamSource(stringReader), new StreamResult(writer));
result = writer.toString();
} catch (IOException e) {
log.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
OR
public String getXmlTemplateRendered(@NonNull final Map<String, String> inputContext,
@NonNull final String templateToRender) {
// Start Time Metric
long startTime = System.currentTimeMillis();
String xmlTemplate = null;
try (StringWriter stringWriter = new StringWriter()) {
StringResourceRepository repository = (StringResourceRepository) velocityEngine.getApplicationAttribute(StringResourceLoader.REPOSITORY_NAME_DEFAULT);
repository.putStringResource(VelocityTemplateConstants.TEMPLATE_TO_RENDER, templateToRender);
setVelocityContext(inputContext, velocityContext);
Template template = velocityEngine.getTemplate(VelocityTemplateConstants.TEMPLATE_TO_RENDER);
template.merge(velocityContext, stringWriter);
xmlTemplate = stringWriter.toString();
} catch (IOException e) {
LOGGER.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
return xmlTemplate;
}
java string stringreader stringwriter metaspace
edited Jan 20 at 7:00
GSerg
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
add a comment |
-1
I am using StringReader and StringWriter as following but in some events this block takes around 5 minutes to execute (whereas it normally completes in milliseconds) and it also raises high metaspace issue. Is there anything I am missing which is leading to memory leak? There are two suspect blocks:
public String getXmlFromXslt(@NonNull final String xmlString, @NonNull final String xsltInput)
throws TransformerException {
// Start Time Metric
long startTime = System.currentTimeMillis();
String result = null;
try (StringReader stringReader = new StringReader(xmlString);
StringWriter writer = new StringWriter()) {
TransformerFactory factory = TransformerFactory.newInstance();
Transformer transformer = factory.newTransformer(new StreamSource(new StringReader(xsltInput)));
transformer.transform(new StreamSource(stringReader), new StreamResult(writer));
result = writer.toString();
} catch (IOException e) {
log.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
OR
public String getXmlTemplateRendered(@NonNull final Map<String, String> inputContext,
@NonNull final String templateToRender) {
// Start Time Metric
long startTime = System.currentTimeMillis();
String xmlTemplate = null;
try (StringWriter stringWriter = new StringWriter()) {
StringResourceRepository repository = (StringResourceRepository) velocityEngine.getApplicationAttribute(StringResourceLoader.REPOSITORY_NAME_DEFAULT);
repository.putStringResource(VelocityTemplateConstants.TEMPLATE_TO_RENDER, templateToRender);
setVelocityContext(inputContext, velocityContext);
Template template = velocityEngine.getTemplate(VelocityTemplateConstants.TEMPLATE_TO_RENDER);
template.merge(velocityContext, stringWriter);
xmlTemplate = stringWriter.toString();
} catch (IOException e) {
LOGGER.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
return xmlTemplate;
}
java string stringreader stringwriter metaspace
edited Jan 20 at 7:00
GSerg
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
add a comment |
-1
-1
-1
I am using StringReader and StringWriter as following but in some events this block takes around 5 minutes to execute (whereas it normally completes in milliseconds) and it also raises high metaspace issue. Is there anything I am missing which is leading to memory leak? There are two suspect blocks:
public String getXmlFromXslt(@NonNull final String xmlString, @NonNull final String xsltInput)
throws TransformerException {
// Start Time Metric
long startTime = System.currentTimeMillis();
String result = null;
try (StringReader stringReader = new StringReader(xmlString);
StringWriter writer = new StringWriter()) {
TransformerFactory factory = TransformerFactory.newInstance();
Transformer transformer = factory.newTransformer(new StreamSource(new StringReader(xsltInput)));
transformer.transform(new StreamSource(stringReader), new StreamResult(writer));
result = writer.toString();
} catch (IOException e) {
log.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
OR
public String getXmlTemplateRendered(@NonNull final Map<String, String> inputContext,
@NonNull final String templateToRender) {
// Start Time Metric
long startTime = System.currentTimeMillis();
String xmlTemplate = null;
try (StringWriter stringWriter = new StringWriter()) {
StringResourceRepository repository = (StringResourceRepository) velocityEngine.getApplicationAttribute(StringResourceLoader.REPOSITORY_NAME_DEFAULT);
repository.putStringResource(VelocityTemplateConstants.TEMPLATE_TO_RENDER, templateToRender);
setVelocityContext(inputContext, velocityContext);
Template template = velocityEngine.getTemplate(VelocityTemplateConstants.TEMPLATE_TO_RENDER);
template.merge(velocityContext, stringWriter);
xmlTemplate = stringWriter.toString();
} catch (IOException e) {
LOGGER.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
return xmlTemplate;
}
java string stringreader stringwriter metaspace
edited Jan 20 at 7:00
GSerg
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
I am using StringReader and StringWriter as following but in some events this block takes around 5 minutes to execute (whereas it normally completes in milliseconds) and it also raises high metaspace issue. Is there anything I am missing which is leading to memory leak? There are two suspect blocks:
public String getXmlFromXslt(@NonNull final String xmlString, @NonNull final String xsltInput)
throws TransformerException {
// Start Time Metric
long startTime = System.currentTimeMillis();
String result = null;
try (StringReader stringReader = new StringReader(xmlString);
StringWriter writer = new StringWriter()) {
TransformerFactory factory = TransformerFactory.newInstance();
Transformer transformer = factory.newTransformer(new StreamSource(new StringReader(xsltInput)));
transformer.transform(new StreamSource(stringReader), new StreamResult(writer));
result = writer.toString();
} catch (IOException e) {
log.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
OR
public String getXmlTemplateRendered(@NonNull final Map<String, String> inputContext,
@NonNull final String templateToRender) {
// Start Time Metric
long startTime = System.currentTimeMillis();
String xmlTemplate = null;
try (StringWriter stringWriter = new StringWriter()) {
StringResourceRepository repository = (StringResourceRepository) velocityEngine.getApplicationAttribute(StringResourceLoader.REPOSITORY_NAME_DEFAULT);
repository.putStringResource(VelocityTemplateConstants.TEMPLATE_TO_RENDER, templateToRender);
setVelocityContext(inputContext, velocityContext);
Template template = velocityEngine.getTemplate(VelocityTemplateConstants.TEMPLATE_TO_RENDER);
template.merge(velocityContext, stringWriter);
xmlTemplate = stringWriter.toString();
} catch (IOException e) {
LOGGER.error(LoggerMessageConstants.Error.IO_EXCEPTION_WHILE_CLOSING_RESOURCES, e);
} finally {
// End Time Metric
}
return xmlTemplate;
}
java string stringreader stringwriter metaspace
java string stringreader stringwriter metaspace
edited Jan 20 at 7:00
GSerg
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
edited Jan 20 at 7:00
GSerg
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
edited Jan 20 at 7:00
GSerg
59.5k14103225
edited Jan 20 at 7:00
GSerg
59.5k14103225
edited Jan 20 at 7:00
GSerg
59.5k14103225
59.5k14103225
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
asked Jan 20 at 6:55
Abhinav Kaushal KeshariAbhinav Kaushal Keshari
846
846
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54274265%2fmemory-leak-using-stringwriter-and-stringreader%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54274265%2fmemory-leak-using-stringwriter-and-stringreader%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
