NET Server mappath security vulnerability for getting web.config access












0















I have the following code in my MVC application for downloading App_Data server generated files.



public ActionResult DownloadFile(string fileName, string dummyName)
{
var path = this.HttpContext.Server.MapPath("~/App_Data/TempFiles");
var filePath = Path.Combine(path, fileName);
var fileExtension = Path.GetExtension(filePath);

byte fileBytes = System.IO.File.ReadAllBytes(filePath);

var cookie = new System.Web.HttpCookie("fileDownload", "true")
{
Expires = DateTime.Now.AddDays(1),
Path = "/"
};
this.Response.Cookies.Add(cookie);

return File(fileBytes, "application/octet-stream", fileName);
}


Seems all fine without issue, but then by looking into security vulnerabilities I could use post man to send something like this:



http://localhost/testapp/employee/downloadfile/?filename=netspi- notafile.xxx../../../../web.config&dummyName=netspi-notafile.xxx


And surprise.. I could get back the web.config contents.




Any clue on how to protect this or prevent this to happen?











share|improve this question



























    0















    I have the following code in my MVC application for downloading App_Data server generated files.



    public ActionResult DownloadFile(string fileName, string dummyName)
    {
    var path = this.HttpContext.Server.MapPath("~/App_Data/TempFiles");
    var filePath = Path.Combine(path, fileName);
    var fileExtension = Path.GetExtension(filePath);

    byte fileBytes = System.IO.File.ReadAllBytes(filePath);

    var cookie = new System.Web.HttpCookie("fileDownload", "true")
    {
    Expires = DateTime.Now.AddDays(1),
    Path = "/"
    };
    this.Response.Cookies.Add(cookie);

    return File(fileBytes, "application/octet-stream", fileName);
    }


    Seems all fine without issue, but then by looking into security vulnerabilities I could use post man to send something like this:



    http://localhost/testapp/employee/downloadfile/?filename=netspi- notafile.xxx../../../../web.config&dummyName=netspi-notafile.xxx


    And surprise.. I could get back the web.config contents.




    Any clue on how to protect this or prevent this to happen?











    share|improve this question

























      0












      0








      0


      1






      I have the following code in my MVC application for downloading App_Data server generated files.



      public ActionResult DownloadFile(string fileName, string dummyName)
      {
      var path = this.HttpContext.Server.MapPath("~/App_Data/TempFiles");
      var filePath = Path.Combine(path, fileName);
      var fileExtension = Path.GetExtension(filePath);

      byte fileBytes = System.IO.File.ReadAllBytes(filePath);

      var cookie = new System.Web.HttpCookie("fileDownload", "true")
      {
      Expires = DateTime.Now.AddDays(1),
      Path = "/"
      };
      this.Response.Cookies.Add(cookie);

      return File(fileBytes, "application/octet-stream", fileName);
      }


      Seems all fine without issue, but then by looking into security vulnerabilities I could use post man to send something like this:



      http://localhost/testapp/employee/downloadfile/?filename=netspi- notafile.xxx../../../../web.config&dummyName=netspi-notafile.xxx


      And surprise.. I could get back the web.config contents.




      Any clue on how to protect this or prevent this to happen?











      share|improve this question














      I have the following code in my MVC application for downloading App_Data server generated files.



      public ActionResult DownloadFile(string fileName, string dummyName)
      {
      var path = this.HttpContext.Server.MapPath("~/App_Data/TempFiles");
      var filePath = Path.Combine(path, fileName);
      var fileExtension = Path.GetExtension(filePath);

      byte fileBytes = System.IO.File.ReadAllBytes(filePath);

      var cookie = new System.Web.HttpCookie("fileDownload", "true")
      {
      Expires = DateTime.Now.AddDays(1),
      Path = "/"
      };
      this.Response.Cookies.Add(cookie);

      return File(fileBytes, "application/octet-stream", fileName);
      }


      Seems all fine without issue, but then by looking into security vulnerabilities I could use post man to send something like this:



      http://localhost/testapp/employee/downloadfile/?filename=netspi- notafile.xxx../../../../web.config&dummyName=netspi-notafile.xxx


      And surprise.. I could get back the web.config contents.




      Any clue on how to protect this or prevent this to happen?








      security asp.net-mvc-4 web-config






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Jan 19 at 18:45









      VAAAVAAA

      5,6551570157




      5,6551570157
























          0






          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54270272%2fnet-server-mappath-security-vulnerability-for-getting-web-config-access%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54270272%2fnet-server-mappath-security-vulnerability-for-getting-web-config-access%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Liquibase includeAll doesn't find base path

          How to use setInterval in EJS file?

          Petrus Granier-Deferre